[Asterisk-code-review] app_confbridge: New option to prevent answer supervision (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15918 )

Change subject: app_confbridge: New option to prevent answer supervision
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Out of curiosity, what's the use case for not answering the channel and how are you planning on answering it?  AMI?

https://gerrit.asterisk.org/c/asterisk/+/15918/1/apps/confbridge/conf_config_parser.c 
File apps/confbridge/conf_config_parser.c:

https://gerrit.asterisk.org/c/asterisk/+/15918/1/apps/confbridge/conf_config_parser.c@2419 
PS1, Line 2419: 	/* Negative logic. Defaults to "yes" and evaluates with ast_false(). If !ast_false(), USER_OPT_NOANSWER is cleared */
              : 	aco_option_register(&cfg_info, "answer_channel", ACO_EXACT, user_types, "yes", OPT_BOOLFLAG_T, 0, FLDSET(struct user_profile, flags), USER_OPT_NOANSWER);
The negative logic is a bit confusing.  I'd stick to 
"answer_channel" and USER_OPT_ANSWER_CHANNEL which defaults to "yes"



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15918
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26642729d0345f178c7b8045506605c8402de54b
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 21 May 2021 12:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210521/6e1bc7c6/attachment.html>