[Asterisk-code-review] loader: Output warnings for deprecated modules. (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15625 )

Change subject: loader: Output warnings for deprecated modules.
......................................................................


Patch Set 4:

(1 comment)

> Patch Set 4:
> 
> > Patch Set 4:
> > 
> > > Patch Set 4:
> > > 
> > > Curious what startup performance (time) is with & without this.
> > 
> > I didn't notice anything tangible when I was testing, but we could figure out an actual value although it'd differ between systems of course.
> 
> I just want a before and after if it wasn't too much trouble.

I can give it a test this afternoon.

https://gerrit.asterisk.org/c/asterisk/+/15625/4/main/loader.c 
File main/loader.c:

https://gerrit.asterisk.org/c/asterisk/+/15625/4/main/loader.c@2423 
PS4, Line 2423: 		results = ast_xmldoc_query("/docs/module[@name='%s']/support_level", mod_name);
              : 		support_level[0] = '\0';
              : 		if (results) {
              : 			const char *result_tmp = ast_xml_get_text(ast_xml_xpath_get_first_result(results));
              : 			if (!ast_strlen_zero(result_tmp)) {
              : 				ast_copy_string(support_level, result_tmp, sizeof(support_level));
              : 			}
              : 			ast_xml_xpath_results_free(results);
              : 		}
> This can be removed, we never use support_level.

Yeah, I removed the need so I'll remove this.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15625
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2080dab97d2186be94c421b41dabf6d79a11611a
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 4
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 17:55:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210331/f2b5f2c8/attachment.html>