<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Curious what startup performance (time) is with & without this.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I didn't notice anything tangible when I was testing, but we could figure out an actual value although it'd differ between systems of course.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I just want a before and after if it wasn't too much trouble.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I can give it a test this afternoon.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15625">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15625/4/main/loader.c">File main/loader.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15625/4/main/loader.c@2423">Patch Set #4, Line 2423:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">              results = ast_xmldoc_query("/docs/module[@name='%s']/support_level", mod_name);<br>             support_level[0] = '\0';<br>              if (results) {<br>                        const char *result_tmp = ast_xml_get_text(ast_xml_xpath_get_first_result(results));<br>                   if (!ast_strlen_zero(result_tmp)) {<br>                           ast_copy_string(support_level, result_tmp, sizeof(support_level));<br>                    }<br>                     ast_xml_xpath_results_free(results);<br>          }<br></pre></blockquote></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">This can be removed, we never use support_level.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Yeah, I removed the need so I'll remove this.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15625">change 15625</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15625"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I2080dab97d2186be94c421b41dabf6d79a11611a </div>
<div style="display:none"> Gerrit-Change-Number: 15625 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 31 Mar 2021 17:55:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>