[Asterisk-code-review] res_speech_aeap: Add basic config skeleton and CLI commands. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15699 )

Change subject: res_speech_aeap: Add basic config skeleton and CLI commands.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Just minor comments, nothing else springs to mind regarding other naming.

https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c 
File res/res_speech_aeap.c:

https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c@40 
PS1, Line 40: 				<configOption name="server">
I think this would better be stated as URL to server, since we're doing WS/WSS.


https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c@44 
PS1, Line 44: 				        <synopsis>Optional media codec(s)</synopsis>
Document what happens if this is not specified.


https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c@51 
PS1, Line 51: #define CONFIG_TYPE "server"
I don't think this #define stuff needs to be done.


https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c@105 
PS1, Line 105: 
Check that this is a WS or WSS URL.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15699
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I567ac5148c92b98d29d2ad83421b416b75ffdaa3
Gerrit-Change-Number: 15699
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 09:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210330/a216b7b5/attachment.html>