<p style="white-space: pre-wrap; word-wrap: break-word;">Just minor comments, nothing else springs to mind regarding other naming.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15699">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c">File res/res_speech_aeap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace">                             <configOption name="server"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this would better be stated as URL to server, since we're doing WS/WSS.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c@44">Patch Set #1, Line 44:</a> <code style="font-family:monospace,monospace">                                      <synopsis>Optional media codec(s)</synopsis></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Document what happens if this is not specified.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c@51">Patch Set #1, Line 51:</a> <code style="font-family:monospace,monospace">#define CONFIG_TYPE "server"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think this #define stuff needs to be done.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15699/1/res/res_speech_aeap.c@105">Patch Set #1, Line 105:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Check that this is a WS or WSS URL.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15699">change 15699</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15699"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I567ac5148c92b98d29d2ad83421b416b75ffdaa3 </div>
<div style="display:none"> Gerrit-Change-Number: 15699 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 30 Mar 2021 09:00:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>