[Asterisk-code-review] res_rtp_asterisk: Fix standard deviation calculation (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Mon Mar 29 13:49:09 CDT 2021


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15689 )

Change subject: res_rtp_asterisk: Fix standard deviation calculation
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15689/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/15689/1/res/res_rtp_asterisk.c@4464 
PS1, Line 4464: 
> I'm a little confused by this (although it may have always been this way and may be correct). […]
After some staring, rfc reading, and a bit of testing these calculations seem correct. However, I will add a comment explaining things, and update the variable attribute comments as well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15689
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibc6e18be41c28bed3fde06d612607acc3fbd621f
Gerrit-Change-Number: 15689
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 18:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210329/66bc3caf/attachment-0001.html>


More information about the asterisk-code-review mailing list