[Asterisk-code-review] res_rtp_asterisk: Fix standard deviation calculation (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15689 )

Change subject: res_rtp_asterisk: Fix standard deviation calculation
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15689/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/15689/1/res/res_rtp_asterisk.c@4464 
PS1, Line 4464: 
I'm a little confused by this (although it may have always been this way and may be correct).
calculate_lost_packet_statistics() only gets called when an rtcp report is generated so rxlost_count will only be incremented once for every report.  Shouldn't this be the actual count of packets of which "rxlost" number of packets have been lost?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15689
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibc6e18be41c28bed3fde06d612607acc3fbd621f
Gerrit-Change-Number: 15689
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 26 Mar 2021 12:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210326/623a7471/attachment.html>