[Asterisk-code-review] logging: Add .log to samples and update asterisk.logrotate. (asterisk[master])

[Friendly Automation]

Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/15696 )

Change subject: logging: Add .log to samples and update asterisk.logrotate.
......................................................................

logging: Add .log to samples and update asterisk.logrotate.

Added .log extension to the sample logs in logger.conf.sample so that
they will be able to be opened in the browser when attached to JIRA
tickets. Because of this, asterisk.logrotate has also been updated to
look for .log extensions instead of no extension for log files such as
full and messages.

Change-Id: I5de743c03f08047d6c6cc80cac5019ae0c4c200f
---
M configs/samples/logger.conf.sample
M contrib/scripts/asterisk.logrotate
A doc/UPGRADE-staging/asterisk_logrotate.txt
3 files changed, 16 insertions(+), 7 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/configs/samples/logger.conf.sample b/configs/samples/logger.conf.sample
index 98dd7b6..52f8873 100644
--- a/configs/samples/logger.conf.sample
+++ b/configs/samples/logger.conf.sample
@@ -157,15 +157,15 @@
 ; modes on a production system unless you are in the process of debugging
 ; a specific issue.
 ;
-;debug => debug
-;trace => trace
-;security => security
+;debug.log => error,warning,notice,verbose,debug
+;trace.log => trace
+;security.log => security
 console => notice,warning,error
 ;console => notice,warning,error,debug
-messages => notice,warning,error
-;full => notice,warning,error,debug,verbose,dtmf,fax
+messages.log => notice,warning,error
+;full.log => notice,warning,error,debug,verbose,dtmf,fax
 ;
-;full-json => [json]debug,verbose,notice,warning,error,dtmf,fax
+;full-json.log => [json]debug,verbose,notice,warning,error,dtmf,fax
 ;
 ;syslog keyword : This special keyword logs to syslog facility
 ;
diff --git a/contrib/scripts/asterisk.logrotate b/contrib/scripts/asterisk.logrotate
index 92e6548..f774446 100644
--- a/contrib/scripts/asterisk.logrotate
+++ b/contrib/scripts/asterisk.logrotate
@@ -1,4 +1,4 @@
-__LOGDIR__/debug __LOGDIR__/console __LOGDIR__/full __LOGDIR__/messages __LOGDIR__/*log {
+__LOGDIR__/debug.log __LOGDIR__/console __LOGDIR__/full.log __LOGDIR__/messages.log __LOGDIR__/*log {
 	weekly
 	missingok
 	rotate 52
diff --git a/doc/UPGRADE-staging/asterisk_logrotate.txt b/doc/UPGRADE-staging/asterisk_logrotate.txt
new file mode 100644
index 0000000..2191e51
--- /dev/null
+++ b/doc/UPGRADE-staging/asterisk_logrotate.txt
@@ -0,0 +1,9 @@
+Subject: Log Rotate
+Master-Only: True
+
+The sample logger files have been changed to have .log as their file
+extension. This was done so that when attached to issues on the issue
+tracker, they are able to be opened in the browser for convenience.
+Because of this, the asterisk.logrotate script has been updated to look
+for .log extensions instead of no extension for files such as full
+and messages.

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15696
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5de743c03f08047d6c6cc80cac5019ae0c4c200f
Gerrit-Change-Number: 15696
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210325/7ed65a5c/attachment-0001.html>