<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15696">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging: Add .log to samples and update asterisk.logrotate.<br><br>Added .log extension to the sample logs in logger.conf.sample so that<br>they will be able to be opened in the browser when attached to JIRA<br>tickets. Because of this, asterisk.logrotate has also been updated to<br>look for .log extensions instead of no extension for log files such as<br>full and messages.<br><br>Change-Id: I5de743c03f08047d6c6cc80cac5019ae0c4c200f<br>---<br>M configs/samples/logger.conf.sample<br>M contrib/scripts/asterisk.logrotate<br>A doc/UPGRADE-staging/asterisk_logrotate.txt<br>3 files changed, 16 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configs/samples/logger.conf.sample b/configs/samples/logger.conf.sample</span><br><span>index 98dd7b6..52f8873 100644</span><br><span>--- a/configs/samples/logger.conf.sample</span><br><span>+++ b/configs/samples/logger.conf.sample</span><br><span>@@ -157,15 +157,15 @@</span><br><span> ; modes on a production system unless you are in the process of debugging</span><br><span> ; a specific issue.</span><br><span> ;</span><br><span style="color: hsl(0, 100%, 40%);">-;debug => debug</span><br><span style="color: hsl(0, 100%, 40%);">-;trace => trace</span><br><span style="color: hsl(0, 100%, 40%);">-;security => security</span><br><span style="color: hsl(120, 100%, 40%);">+;debug.log => error,warning,notice,verbose,debug</span><br><span style="color: hsl(120, 100%, 40%);">+;trace.log => trace</span><br><span style="color: hsl(120, 100%, 40%);">+;security.log => security</span><br><span> console => notice,warning,error</span><br><span> ;console => notice,warning,error,debug</span><br><span style="color: hsl(0, 100%, 40%);">-messages => notice,warning,error</span><br><span style="color: hsl(0, 100%, 40%);">-;full => notice,warning,error,debug,verbose,dtmf,fax</span><br><span style="color: hsl(120, 100%, 40%);">+messages.log => notice,warning,error</span><br><span style="color: hsl(120, 100%, 40%);">+;full.log => notice,warning,error,debug,verbose,dtmf,fax</span><br><span> ;</span><br><span style="color: hsl(0, 100%, 40%);">-;full-json => [json]debug,verbose,notice,warning,error,dtmf,fax</span><br><span style="color: hsl(120, 100%, 40%);">+;full-json.log => [json]debug,verbose,notice,warning,error,dtmf,fax</span><br><span> ;</span><br><span> ;syslog keyword : This special keyword logs to syslog facility</span><br><span> ;</span><br><span>diff --git a/contrib/scripts/asterisk.logrotate b/contrib/scripts/asterisk.logrotate</span><br><span>index 92e6548..f774446 100644</span><br><span>--- a/contrib/scripts/asterisk.logrotate</span><br><span>+++ b/contrib/scripts/asterisk.logrotate</span><br><span>@@ -1,4 +1,4 @@</span><br><span style="color: hsl(0, 100%, 40%);">-__LOGDIR__/debug __LOGDIR__/console __LOGDIR__/full __LOGDIR__/messages __LOGDIR__/*log {</span><br><span style="color: hsl(120, 100%, 40%);">+__LOGDIR__/debug.log __LOGDIR__/console __LOGDIR__/full.log __LOGDIR__/messages.log __LOGDIR__/*log {</span><br><span>    weekly</span><br><span>       missingok</span><br><span>    rotate 52</span><br><span>diff --git a/doc/UPGRADE-staging/asterisk_logrotate.txt b/doc/UPGRADE-staging/asterisk_logrotate.txt</span><br><span>new file mode 100644</span><br><span>index 0000000..2191e51</span><br><span>--- /dev/null</span><br><span>+++ b/doc/UPGRADE-staging/asterisk_logrotate.txt</span><br><span>@@ -0,0 +1,9 @@</span><br><span style="color: hsl(120, 100%, 40%);">+Subject: Log Rotate</span><br><span style="color: hsl(120, 100%, 40%);">+Master-Only: True</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+The sample logger files have been changed to have .log as their file</span><br><span style="color: hsl(120, 100%, 40%);">+extension. This was done so that when attached to issues on the issue</span><br><span style="color: hsl(120, 100%, 40%);">+tracker, they are able to be opened in the browser for convenience.</span><br><span style="color: hsl(120, 100%, 40%);">+Because of this, the asterisk.logrotate script has been updated to look</span><br><span style="color: hsl(120, 100%, 40%);">+for .log extensions instead of no extension for files such as full</span><br><span style="color: hsl(120, 100%, 40%);">+and messages.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15696">change 15696</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15696"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5de743c03f08047d6c6cc80cac5019ae0c4c200f </div>
<div style="display:none"> Gerrit-Change-Number: 15696 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>