[Asterisk-code-review] app_queue.c: Remove dead 'updatecdr' code. (asterisk[18])

[Friendly Automation]

Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/15693 )

Change subject: app_queue.c: Remove dead 'updatecdr' code.
......................................................................

app_queue.c: Remove dead 'updatecdr' code.

Also removed the sample documentation, and some oddly-placed
documentation about the timeout argument to the Queue() application
itself. There is a large section on the timeout behavior below.

ASTERISK-26614 #close

Change-Id: I8f84e8304b50305b7c4cba2d9787a5d77c3a6217
---
M apps/app_queue.c
M configs/samples/queues.conf.sample
2 files changed, 0 insertions(+), 20 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/apps/app_queue.c b/apps/app_queue.c
index 153fe6b..d3e0471 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -1484,9 +1484,6 @@
 static struct stasis_subscription *device_state_sub;
 
 /*! \brief queues.conf [general] option */
-static int update_cdr;
-
-/*! \brief queues.conf [general] option */
 static int negative_penalty_invalid;
 
 /*! \brief queues.conf [general] option */
@@ -9206,7 +9203,6 @@
 	queue_persistent_members = 0;
 	autofill_default = 0;
 	montype_default = 0;
-	update_cdr = 0;
 	shared_lastcall = 0;
 	negative_penalty_invalid = 0;
 	log_membername_as_agent = 0;
@@ -9226,9 +9222,6 @@
 		if (!strcasecmp(general_val, "mixmonitor"))
 			montype_default = 1;
 	}
-	if ((general_val = ast_variable_retrieve(cfg, "general", "updatecdr"))) {
-		update_cdr = ast_true(general_val);
-	}
 	if ((general_val = ast_variable_retrieve(cfg, "general", "shared_lastcall"))) {
 		shared_lastcall = ast_true(general_val);
 	}
diff --git a/configs/samples/queues.conf.sample b/configs/samples/queues.conf.sample
index eae5e0e..6d0e4b0 100644
--- a/configs/samples/queues.conf.sample
+++ b/configs/samples/queues.conf.sample
@@ -41,19 +41,6 @@
 ;
 monitor-type = MixMonitor
 ;
-; UpdateCDR behavior.
-;    This option is implemented to mimic chan_agents behavior of populating
-;    CDR dstchannel field of a call with an agent name, which you can set
-;    at the login time with AddQueueMember membername parameter.
-;
-; updatecdr = no
-
-;
-; Note that a timeout to fail out of a queue may be passed as part of
-; an application call from extensions.conf:
-; Queue(queuename,[options],[optionalurl],[announceoverride],[timeout])
-; example: Queue(dave,t,,,45)
-
 ; shared_lastcall will make the lastcall and calls received be the same in
 ; members logged in more than one queue.  This is useful to make the queue
 ; respect the wrapuptime of another queue for a shared member.

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15693
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I8f84e8304b50305b7c4cba2d9787a5d77c3a6217
Gerrit-Change-Number: 15693
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210325/0cd213d7/attachment.html>