<p>Friendly Automation <strong>submitted</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15693">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Joshua Colp: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
Friendly Automation: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_queue.c: Remove dead 'updatecdr' code.<br><br>Also removed the sample documentation, and some oddly-placed<br>documentation about the timeout argument to the Queue() application<br>itself. There is a large section on the timeout behavior below.<br><br>ASTERISK-26614 #close<br><br>Change-Id: I8f84e8304b50305b7c4cba2d9787a5d77c3a6217<br>---<br>M apps/app_queue.c<br>M configs/samples/queues.conf.sample<br>2 files changed, 0 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_queue.c b/apps/app_queue.c</span><br><span>index 153fe6b..d3e0471 100644</span><br><span>--- a/apps/app_queue.c</span><br><span>+++ b/apps/app_queue.c</span><br><span>@@ -1484,9 +1484,6 @@</span><br><span> static struct stasis_subscription *device_state_sub;</span><br><span> </span><br><span> /*! \brief queues.conf [general] option */</span><br><span style="color: hsl(0, 100%, 40%);">-static int update_cdr;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/*! \brief queues.conf [general] option */</span><br><span> static int negative_penalty_invalid;</span><br><span> </span><br><span> /*! \brief queues.conf [general] option */</span><br><span>@@ -9206,7 +9203,6 @@</span><br><span> queue_persistent_members = 0;</span><br><span> autofill_default = 0;</span><br><span> montype_default = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- update_cdr = 0;</span><br><span> shared_lastcall = 0;</span><br><span> negative_penalty_invalid = 0;</span><br><span> log_membername_as_agent = 0;</span><br><span>@@ -9226,9 +9222,6 @@</span><br><span> if (!strcasecmp(general_val, "mixmonitor"))</span><br><span> montype_default = 1;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- if ((general_val = ast_variable_retrieve(cfg, "general", "updatecdr"))) {</span><br><span style="color: hsl(0, 100%, 40%);">- update_cdr = ast_true(general_val);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> if ((general_val = ast_variable_retrieve(cfg, "general", "shared_lastcall"))) {</span><br><span> shared_lastcall = ast_true(general_val);</span><br><span> }</span><br><span>diff --git a/configs/samples/queues.conf.sample b/configs/samples/queues.conf.sample</span><br><span>index eae5e0e..6d0e4b0 100644</span><br><span>--- a/configs/samples/queues.conf.sample</span><br><span>+++ b/configs/samples/queues.conf.sample</span><br><span>@@ -41,19 +41,6 @@</span><br><span> ;</span><br><span> monitor-type = MixMonitor</span><br><span> ;</span><br><span style="color: hsl(0, 100%, 40%);">-; UpdateCDR behavior.</span><br><span style="color: hsl(0, 100%, 40%);">-; This option is implemented to mimic chan_agents behavior of populating</span><br><span style="color: hsl(0, 100%, 40%);">-; CDR dstchannel field of a call with an agent name, which you can set</span><br><span style="color: hsl(0, 100%, 40%);">-; at the login time with AddQueueMember membername parameter.</span><br><span style="color: hsl(0, 100%, 40%);">-;</span><br><span style="color: hsl(0, 100%, 40%);">-; updatecdr = no</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-;</span><br><span style="color: hsl(0, 100%, 40%);">-; Note that a timeout to fail out of a queue may be passed as part of</span><br><span style="color: hsl(0, 100%, 40%);">-; an application call from extensions.conf:</span><br><span style="color: hsl(0, 100%, 40%);">-; Queue(queuename,[options],[optionalurl],[announceoverride],[timeout])</span><br><span style="color: hsl(0, 100%, 40%);">-; example: Queue(dave,t,,,45)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> ; shared_lastcall will make the lastcall and calls received be the same in</span><br><span> ; members logged in more than one queue. This is useful to make the queue</span><br><span> ; respect the wrapuptime of another queue for a shared member.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15693">change 15693</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15693"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I8f84e8304b50305b7c4cba2d9787a5d77c3a6217 </div>
<div style="display:none"> Gerrit-Change-Number: 15693 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>