[Asterisk-code-review] app_queue: Add alembic migration to add ringinuse to queue_members. (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15697 )

Change subject: app_queue: Add alembic migration to add ringinuse to queue_members.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15697/1/contrib/ast-db-manage/config/versions/8915fcc5766f_add_ringinuse_to_queue_members.py 
File contrib/ast-db-manage/config/versions/8915fcc5766f_add_ringinuse_to_queue_members.py:

https://gerrit.asterisk.org/c/asterisk/+/15697/1/contrib/ast-db-manage/config/versions/8915fcc5766f_add_ringinuse_to_queue_members.py@1 
PS1, Line 1: """Add ringinuse to queue_members
Should always use the ast_bool_values rather than simple yes/no for new boolean columns to avoid inconsistencies between what is in the database and what is shown by the CLI.

Several examples can be found in other scripts.

AST_BOOL_NAME = 'ast_bool_values'
# We'll just ignore the n/y and f/t abbreviations as Asterisk does not write
# those aliases.
AST_BOOL_VALUES = [ '0', '1',
                    'off', 'on',
                    'false', 'true',
                    'no', 'yes' ]



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15697
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I53a1bfdd3113d620bea88349019173a2f3f0ae39
Gerrit-Change-Number: 15697
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 24 Mar 2021 21:38:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210324/c463753b/attachment.html>