<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15697">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15697/1/contrib/ast-db-manage/config/versions/8915fcc5766f_add_ringinuse_to_queue_members.py">File contrib/ast-db-manage/config/versions/8915fcc5766f_add_ringinuse_to_queue_members.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15697/1/contrib/ast-db-manage/config/versions/8915fcc5766f_add_ringinuse_to_queue_members.py@1">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">"""Add ringinuse to queue_members</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should always use the ast_bool_values rather than simple yes/no for new boolean columns to avoid inconsistencies between what is in the database and what is shown by the CLI.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Several examples can be found in other scripts.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">AST_BOOL_NAME = 'ast_bool_values'<br># We'll just ignore the n/y and f/t abbreviations as Asterisk does not write<br># those aliases.<br>AST_BOOL_VALUES = [ '0', '1',<br>                    'off', 'on',<br>                    'false', 'true',<br>                    'no', 'yes' ]</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15697">change 15697</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15697"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I53a1bfdd3113d620bea88349019173a2f3f0ae39 </div>
<div style="display:none"> Gerrit-Change-Number: 15697 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 24 Mar 2021 21:38:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>