[Asterisk-code-review] res_pjsip_messaging: Allow setting domain of recipient (asterisk[18])

[Brian J. Murrell]

Brian J. Murrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15597 )

Change subject: res_pjsip_messaging: Allow setting domain of recipient
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15597/3/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15597/3/res/res_pjsip_messaging.c@232 
PS3, Line 232: 	parsed_name_addr = (pjsip_name_addr *) pjsip_parse_uri(tdata->pool, to, strlen(to),
> This parses the full URI, including domain portion, is there a reason not to use that instead of doi […]
Nothing other than the ignorance of the seemingly pretty complicated PJSIP library -- at least from the perspective of somebody who has never used it before.

I tried looking at https://www.pjsip.org/pjsip/docs/html/structpjsip__uri.htm as it's the return value of pjsip_parse_uri() but again, as somebody unfamiliar with the overall structure of the PJSIP library, it doesn't really mean much to me.

I'd be happy to take any pointers, suggestions, etc. and incorporate them into this patch.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15597
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I26fb8605d7cb200332a0442879fd9a5679a65022
Gerrit-Change-Number: 15597
Gerrit-PatchSet: 3
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 10 Mar 2021 21:34:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210310/fdb6bf10/attachment.html>