<p><a href="https://gerrit.asterisk.org/c/asterisk/+/15597">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15597/3/res/res_pjsip_messaging.c">File res/res_pjsip_messaging.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15597/3/res/res_pjsip_messaging.c@232">Patch Set #3, Line 232:</a> <code style="font-family:monospace,monospace">      parsed_name_addr = (pjsip_name_addr *) pjsip_parse_uri(tdata->pool, to, strlen(to),</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This parses the full URI, including domain portion, is there a reason not to use that instead of doi […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nothing other than the ignorance of the seemingly pretty complicated PJSIP library -- at least from the perspective of somebody who has never used it before.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I tried looking at https://www.pjsip.org/pjsip/docs/html/structpjsip__uri.htm as it's the return value of pjsip_parse_uri() but again, as somebody unfamiliar with the overall structure of the PJSIP library, it doesn't really mean much to me.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd be happy to take any pointers, suggestions, etc. and incorporate them into this patch.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15597">change 15597</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15597"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I26fb8605d7cb200332a0442879fd9a5679a65022 </div>
<div style="display:none"> Gerrit-Change-Number: 15597 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Brian J. Murrell <brian@interlinx.bc.ca> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 10 Mar 2021 21:34:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>