[Asterisk-code-review] res_pjsip_caller_id: Add ANI2/OLI parsing (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Stanislav Abramenkov.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16041 )

Change subject: res_pjsip_caller_id: Add ANI2/OLI parsing
......................................................................


Patch Set 8: Code-Review+1

(6 comments)

Patchset:

PS8: 
Go ahead and cherry-pick to 16 and 18.


File include/asterisk/res_pjsip_session.h:

https://gerrit.asterisk.org/c/asterisk/+/16041/comment/322291df_aa3fa208 
PS7, Line 208: 	/*! Originating Line Info (ANI II digits) */
             : 	int ani2;
> Because ast_sip_session is a public interface, new fields have to go at the end of the structure.
Done


File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/c/asterisk/+/16041/comment/0a300356_5b6dc25f 
PS1, Line 414: 		
> Redness
Done


File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/c/asterisk/+/16041/comment/809c7099_31381145 
PS2, Line 146: 		return ast_str_to_int(oli1->value.ptr, ani2);
             : 	} else if ((oli2 = pjsip_param_find(&from_hdr->other_param, &oli_str2))) {
             : 		return ast_str_to_int(oli2->value.ptr, ani2);
             : 	} else if ((oli3 = pjsip_param_find(&from_hdr->other_param, &oli_str3))) {
             : 		return ast_str_to_int(oli3->value.ptr, ani2);
> You can't use the pj_str_t ptr directly as a char * because it's not null terminated. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16041/comment/d7080bed_c296e5be 
PS2, Line 407: 		struct ast_party_caller caller;
> Other than initializing this, it doesn't look used.
Done


https://gerrit.asterisk.org/c/asterisk/+/16041/comment/5d3c9033_02ddae07 
PS2, Line 416: 			ast_party_caller_init(&caller);
> > This is just the way that ANI2 is initialized in other places throughout the code base. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16041
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifc938a7a7d45ce33999ebf3656a542226f6d3847
Gerrit-Change-Number: 16041
Gerrit-PatchSet: 8
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 12:50:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210623/480a844e/attachment-0001.html>