[Asterisk-code-review] Take the transfer target off hold when handling INVITE-with-Replaces. (asterisk[15.7])

Ben Smithurst asteriskteam at digium.com
Wed Jun 9 03:29:49 CDT 2021


Ben Smithurst has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/16042 )


Change subject: Take the transfer target off hold when handling INVITE-with-Replaces.
......................................................................

Take the transfer target off hold when handling INVITE-with-Replaces.

This fixes a problem with attended remote transfers, where the phone
puts the target on hold immediately before sending REFER to another
server, when the calls are on different servers.  When the REFER
is routed across to the other server using an external_replaces hook
the on hold call is removed from hold again and the transfer continues
normally.

Change-Id: Ibfe359c5ce0338b2df9d1b2347bc684d4a21461a
---
M res/res_pjsip_refer.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/42/16042/1

diff --git a/res/res_pjsip_refer.c b/res/res_pjsip_refer.c
index 750894b..1c0ff93 100644
--- a/res/res_pjsip_refer.c
+++ b/res/res_pjsip_refer.c
@@ -982,6 +982,9 @@
 	ast_debug(3, "INVITE with Replaces being attempted.  '%s' --> '%s'\n",
 		ast_channel_name(session->channel), ast_channel_name(invite.channel));
 
+	/* Take the transfer target off hold. */
+	ast_queue_unhold(invite.channel);
+
 	if (!invite.bridge) {
 		struct ast_channel *chan = session->channel;
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16042
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15.7
Gerrit-Change-Id: Ibfe359c5ce0338b2df9d1b2347bc684d4a21461a
Gerrit-Change-Number: 16042
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Smithurst <ben.smithurst at gradwell.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210609/458230ae/attachment.html>


More information about the asterisk-code-review mailing list