[Asterisk-code-review] res_pjsip_caller_id: Add ANI2/OLI parsing (asterisk[master])

[George Joseph]

Attention is currently required from: N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16041 )

Change subject: res_pjsip_caller_id: Add ANI2/OLI parsing
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

File include/asterisk/res_pjsip_session.h:

https://gerrit.asterisk.org/c/asterisk/+/16041/comment/80902216_805344fd 
PS7, Line 208: 	/*! Originating Line Info (ANI II digits) */
             : 	int ani2;
Because ast_sip_session is a public interface, new fields have to go at the end of the structure.


File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/c/asterisk/+/16041/comment/a4819d55_898d6669 
PS6, Line 438: 		update_incoming_connected_line(session, rdata);
> I believe for connected line updates, ANI2 is already handled (there's ani2 references here already that I didn't add). Just the parsing into a new channel is what is missing currently.

Gotcha.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16041
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifc938a7a7d45ce33999ebf3656a542226f6d3847
Gerrit-Change-Number: 16041
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 14:46:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210622/4e649d94/attachment.html>