[Asterisk-code-review] res_pjsip_caller_id: Add ANI2/OLI parsing (asterisk[master])

[N A]

Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16041 )

Change subject: res_pjsip_caller_id: Add ANI2/OLI parsing
......................................................................


Patch Set 6:

(5 comments)

File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/c/asterisk/+/16041/comment/f653e53f_87fb4f55 
PS3, Line 136: 	char oli[4];
> oli needs to be large enough to hold the string representation of the largest integer you expect, pl […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/16041/comment/b9a4668d_d49c7a43 
PS3, Line 147: 		ast_copy_pj_str(oli, &oli1->value, sizeof(oli));
> Replace sizeof(oli) with MAX_OLI_DIGITS.
Ack


https://gerrit.asterisk.org/c/asterisk/+/16041/comment/4a3bc899_3b11700a 
PS3, Line 148: 		return ast_str_to_int(oli1->value.ptr, ani2);
> You're still using the pj_str directly.  You need to use oli now.
Ack


File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/c/asterisk/+/16041/comment/453ad992_8dc83d3a 
PS6, Line 420: session->channel
> session->channel is going to be NULL here. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16041/comment/d5545539_d7ac8e6a 
PS6, Line 438: 		update_incoming_connected_line(session, rdata);
> Do you also have to handle this case?
I believe for connected line updates, ANI2 is already handled (there's ani2 references here already that I didn't add). Just the parsing into a new channel is what is missing currently.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16041
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifc938a7a7d45ce33999ebf3656a542226f6d3847
Gerrit-Change-Number: 16041
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 14:04:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210622/0b4db5df/attachment.html>