[Asterisk-code-review] res_pjsip_refer: Fix issue with transfer target being left on hold. (asterisk[16])

[Joshua Colp]

Attention is currently required from: Sean Bright, Ben Smithurst.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16042 )

Change subject: res_pjsip_refer: Fix issue with transfer target being left on hold.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16042/comment/6f759857_fec6c921 
PS3, Line 9: This fixes a problem with attended remote transfers, where the phone
This commit message can be confusing, because it makes it seem as though external_replaces is required for this to happen. In reality it's the INVITE with Replaces functionality itself, which anything could conceivably use when talking to us.


File res/res_pjsip_refer.c:

https://gerrit.asterisk.org/c/asterisk/+/16042/comment/ac3d8014_fe2b547a 
PS3, Line 1022: 	/* Take the transfer target off hold. */
I think this needs an explanation for why this is special and required here. In the REFER case we leverage the bridge attended transfer code, which takes care of unhold for us. In the INVITE with Replaces case we don't use that and are required to queue the unhold ourselves here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16042
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibfe359c5ce0338b2df9d1b2347bc684d4a21461a
Gerrit-Change-Number: 16042
Gerrit-PatchSet: 3
Gerrit-Owner: Ben Smithurst <ben.smithurst at gradwell.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Ben Smithurst <ben.smithurst at gradwell.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 10:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210615/2b4be10d/attachment.html>