<p> Attention is currently required from: Sean Bright, Ben Smithurst. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16042">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16042/comment/6f759857_fec6c921">Patch Set #3, Line 9:</a> <code style="font-family:monospace,monospace">This fixes a problem with attended remote transfers, where the phone</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This commit message can be confusing, because it makes it seem as though external_replaces is required for this to happen. In reality it's the INVITE with Replaces functionality itself, which anything could conceivably use when talking to us.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_refer.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16042/comment/ac3d8014_fe2b547a">Patch Set #3, Line 1022:</a> <code style="font-family:monospace,monospace"> /* Take the transfer target off hold. */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this needs an explanation for why this is special and required here. In the REFER case we leverage the bridge attended transfer code, which takes care of unhold for us. In the INVITE with Replaces case we don't use that and are required to queue the unhold ourselves here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16042">change 16042</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16042"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ibfe359c5ce0338b2df9d1b2347bc684d4a21461a </div>
<div style="display:none"> Gerrit-Change-Number: 16042 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Ben Smithurst <ben.smithurst@gradwell.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Ben Smithurst <ben.smithurst@gradwell.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 15 Jun 2021 10:27:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>