[Asterisk-code-review] translate.c: Fixed codec translator bug (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Kevin Harwell.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15953 )

Change subject: translate.c: Fixed codec translator bug
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File main/translate.c:

https://gerrit.asterisk.org/c/asterisk/+/15953/comment/aa8ae0f0_91971726 
PS2, Line 1385: int ast_translator_better_quality(struct ast_format *src, struct ast_format *best) {
I don't think this should be accepted as implemented. It is limited to specific codecs for a particular situation, and is not pluggable. I think a mechanism should be added that allows codecs to define their quality (on some kind of arbitrary scale) which can then be used to take quality into account. I don't know precisely what that would look like.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4b7297e1baca7aac14fe4a3c7538e18e2dbe9fd6
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210608/79e15bd9/attachment-0001.html>