[Asterisk-code-review] translate.c: Fixed codec translator bug (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15953 )

Change subject: translate.c: Fixed codec translator bug
......................................................................


Patch Set 2:

(2 comments)

File include/asterisk/translate.h:

https://gerrit.asterisk.org/c/asterisk/+/15953/comment/e4acb85e_e83fce14 
PS1, Line 293: int ast_translator_better_quality(int c1, int c2);
> I'd pass in a pointer to the formats themselves, and then retrieve c1 & c2 within. […]
Done


File main/translate.c:

https://gerrit.asterisk.org/c/asterisk/+/15953/comment/7fe35911_b9c382f1 
PS1, Line 1499: 				} else if (gap_current == gap_selected) {
              : 					if (ast_translator_better_quality(
              : 						ast_format_get_codec_id(src), ast_format_get_codec_id(best))) {
> I think if you wanted you could combine this with the above to reduce some code duplication? […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4b7297e1baca7aac14fe4a3c7538e18e2dbe9fd6
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 15:32:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210602/4c855b70/attachment.html>