[Asterisk-code-review] func_sayfiles: Retrieve say file names (asterisk[master])

N A asteriskteam at digium.com
Thu Jul 29 16:20:04 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16226 )

Change subject: func_sayfiles: Retrieve say file names
......................................................................


Patch Set 2:

(1 comment)

File include/asterisk/say.h:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/933385b4_43046ba2 
PS2, Line 191: struct ast_str* ast_get_character_str_full(const char *str, const char *lang, enum ast_say_case_sensitivity sensitivity);
> Any new API calls should have accompanying doxygen documentation for them. […]
Are you sure about this? func_sayfiles no longer compiles if I move it into the C++. If I move it back out, this issue goes away. Otherwise, func_sayfiles thinks these are all undefined, and being defined for the first time.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16226
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If9718c89353b8e153d84add3cc4637b79585db19
Gerrit-Change-Number: 16226
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 29 Jul 2021 21:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210729/5be5498d/attachment.html>


More information about the asterisk-code-review mailing list