[Asterisk-code-review] func_sayfiles: Retrieve say file names (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Jul 29 07:06:57 CDT 2021


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16226 )

Change subject: func_sayfiles: Retrieve say file names
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS2: 
Just a first pass.


File doc/CHANGES-staging/say.txt:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/4fc9b25a_62fb3dd9 
PS2, Line 3: Refactors some code in say.c so that other Asterisk
CHANGES are generally for users, so this should actually talk about the dialplan function.


File include/asterisk/say.h:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/d3156704_caa59ce5 
PS2, Line 191: struct ast_str* ast_get_character_str_full(const char *str, const char *lang, enum ast_say_case_sensitivity sensitivity);
Any new API calls should have accompanying doxygen documentation for them. Older API calls predate this and generally don't have it, such as the existing stuff.

As well this should be in the __cplusplus and c_plusplus block.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16226
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If9718c89353b8e153d84add3cc4637b79585db19
Gerrit-Change-Number: 16226
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 29 Jul 2021 12:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210729/43e68c8a/attachment.html>


More information about the asterisk-code-review mailing list