[Asterisk-code-review] app_sendmf: New SendMF application (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Sarah Autumn.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16080 )

Change subject: app_sendmf: New SendMF application
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

File apps/app_sendmf.c:

https://gerrit.asterisk.org/c/asterisk/+/16080/comment/e7b5492d_ecae1ab9 
PS2, Line 82: static int ast_senddigit_mf_begin(struct ast_channel *chan, char digit)
ast_* is commonly used as a prefix to indicate a function used across the tree, not within a module itself.


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/e3dbb243_a4addd74 
PS2, Line 116: 		ast_debug(1, "Unable to generate MF tone '%c' for '%s'\n", digit, ast_channel_name(chan));
Should this be a non-debug message so the user is aware of what has happened?


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/32caefaa_1dc1771c 
PS2, Line 232: 	if (peer && ast_autoservice_start(peer)) {
Why/how could there be a peer?


File doc/CHANGES-staging/app_sendmf.txt:

https://gerrit.asterisk.org/c/asterisk/+/16080/comment/1c9a3eea_8098b04d 
PS2, Line 5: tones on a channel.
This isn't actually complete accurate. It allows you to send it on the current channel, or an arbitrary channel name passed in.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 12:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210729/57409310/attachment-0001.html>