[Asterisk-code-review] app_sendmf: New SendMF application (asterisk[master])

N A asteriskteam at digium.com
Mon Jul 5 08:12:37 CDT 2021


Attention is currently required from: Sarah Autumn.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16080 )

Change subject: app_sendmf: New SendMF application
......................................................................


Patch Set 1:

(1 comment)

File apps/app_sendmf.c:

https://gerrit.asterisk.org/c/asterisk/+/16080/comment/3280f3fa_5f0d763f 
PS1, Line 95: 		"1100+1700", /* K (KP) */
> This differs from the characters used for KP, ST, etc in sig_analog.c (for example, line 1860). […]
Ah, thanks for pointing that out.
I actually like the sig_analog approach better and have changed my notation to match that. * and # at least is a common convention for KP and ST even outside of sig_analog so it makes sense to match that, the TUV thing was rather arbitrary as it was.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Mon, 05 Jul 2021 13:12:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210705/610f1372/attachment.html>


More information about the asterisk-code-review mailing list