[Asterisk-code-review] sig_analog: Changes to improve electromechanical signalling compatibi... (asterisk[master])

[Sarah Autumn]

Attention is currently required from: N A.
Sarah Autumn has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16151 )

Change subject: sig_analog: Changes to improve electromechanical signalling compatibility
......................................................................


Patch Set 3:

(1 comment)

File channels/sig_analog.c:

https://gerrit.asterisk.org/c/asterisk/+/16151/comment/2c750117_f9bb3ea7 
PS2, Line 1980: 				pbx_builtin_setvar_helper(chan, "ANI2", anibuf + 1);
> I see you have it storing OLI digits in CALLERID(ANI2) now, but it's still writing to the "ANI2" cha […]
I left ANI2 there on purpose. Asterisk's caller->ani2 wants an int, but I feel like ANI2 is best expressed as a string. My "ANI2" variable does that.

In cases where there are two ANI INFO digits, the first digit is usually a zero. When we 'int' it, that zero is lost, and only the nonzero digits remain. That rubs me the wrong way, since even though the nonzero digits are preserved, its still not "right", according to the book.

I specifically don't want to mess with Asterisk's feelings on what caller->ani2 should be. I do not want to add another element to the structure, since this is definitely outside the scope of what I wanted to address with this fix.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
Gerrit-Change-Number: 16151
Gerrit-PatchSet: 3
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 16:58:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210728/16dc9c56/attachment.html>