[Asterisk-code-review] sig_analog: Changes to improve electromechanical signalling compatibi... (asterisk[master])

[N A]

Attention is currently required from: Sarah Autumn.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16151 )

Change subject: sig_analog: Changes to improve electromechanical signalling compatibility
......................................................................


Patch Set 3:

(1 comment)

File channels/sig_analog.c:

https://gerrit.asterisk.org/c/asterisk/+/16151/comment/b3976d81_a3d900e1 
PS2, Line 1980: 				pbx_builtin_setvar_helper(chan, "ANI2", anibuf + 1);
> Ah, I see what you mean. […]
I see you have it storing OLI digits in CALLERID(ANI2) now, but it's still writing to the "ANI2" channel variable, is that intentional? "ANISTART" as I understand is new information not corresponding to a caller ID field, but "ANI2" seems unneeded at this point - correct me if I'm wrong!



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
Gerrit-Change-Number: 16151
Gerrit-PatchSet: 3
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Mon, 26 Jul 2021 11:41:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210726/4ac97c3f/attachment.html>