[Asterisk-code-review] res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts (asterisk[16])

[Joshua Colp]

Attention is currently required from: Joe.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16160 )

Change subject: res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts
......................................................................


Patch Set 2:

(1 comment)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16160/comment/2f1d2f23_41fc638a 
PS2, Line 15: This commit changes this behavior, to remove unavailable contacts
> Understood, and usually I would fully agree with this hesitation. […]
This is the first time such behavior you've added has ever been mentioned that I've personally seen. People seem to find the existing behavior fine and acceptable for them. That is what prompted my response - if there was an overwhelming desire or issue with existing behavior from the user community then I'd think otherwise, but it's been quiet. That is why I think it should remain as-is. I've felt the pain of changing something by default only to have unexpected consequences for users and having to deal with it and it's not something I want to repeat. Other people can chime in if they wish.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16160
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2711b08f2b4d1177411b1be23e970d7fdff5784
Gerrit-Change-Number: 16160
Gerrit-PatchSet: 2
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joe <ynadiv at corpit.xyz>
Gerrit-Comment-Date: Mon, 26 Jul 2021 14:27:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210726/988fce1b/attachment.html>