[Asterisk-code-review] res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts (asterisk[16])

[Joe]

Attention is currently required from: Joshua Colp.
Joe has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16160 )

Change subject: res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts
......................................................................


Patch Set 2:

(1 comment)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16160/comment/9940c859_1f8e7ebf 
PS2, Line 15: This commit changes this behavior, to remove unavailable contacts
> I'm not comfortable changing default behavior which has existed for quite a few years at this point. […]
Understood, and usually I would fully agree with this hesitation.

In this case, I think the existing behavior is incorrect and undesirable, in that it will either remove a qualifying existing contact over one that is unavailable, which results in DoS, or deny a valid registration on account of an unavailable contact, resulting in DoS.  I cannot think of a case where the change here would be unwelcome or break something anyone was relying on.

Of course as the project maintainers you all have a better global view of how this project is used, so if you still maintain your opinion I can work on making this an option, but like I said I don't really agree.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16160
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2711b08f2b4d1177411b1be23e970d7fdff5784
Gerrit-Change-Number: 16160
Gerrit-PatchSet: 2
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 14:22:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210726/73076b88/attachment.html>