[Asterisk-code-review] func_lookup: Fork of HINT function (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_lookup: Fork of HINT function
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> Could you clarify what you mean by this exactly? The function would already be self-contained, exten […]
I personally still wouldn't like to see it in the tree because I disagree with configuring it from the dialplan. My comment was that if you made that change, it would be easier to maintain it out of tree than also patching Asterisk.

The DB function does not suffer from this because you don't configure it in the dialplan. Call routing may cause it to execute, but it's not configured from the dialplan.

Your thing is also still a key value store. The value can just be interpreted, and the key can be found using a pattern match.

I've said my part multiple times now both on IRC and in this review. I've left it open to other regular Asterisk developers and contributors as to their opinion to see if they have a different view on the matter. If they do that may change things.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 00:06:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/9552779f/attachment.html>