[Asterisk-code-review] func_lookup: Fork of HINT function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_lookup: Fork of HINT function
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> If you do want to do it that way, you can have the module be external and maintain it yourself as a  […]
Could you clarify what you mean by this exactly? The function would already be self-contained, extended support, with no impact to anything else as I described, and there is nothing special then differentiating such a lookup context from any other context. You could, in theory, just as well use it to retrieve the application at an extension in any context. It dictates nothing about specific use cases.

Even the old iteration, calling it key/value is an oversimplification. There isn't anything key value about:
exten => _3XX,lookup,${CURL(http://example.com/api?clid=${CALLERID(num)}&exten=${EXTEN})}

By that same logic, the DB function suffers from the same issue so I'm not quite sure I follow.

Anyhow, regardless, the new approach I described would be about as simple and minimally disruptive (really, non-disruptive) as I can envision this. If you think this is better I can shift to doing it that way, no core changes, a fully isolated module.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 00:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/6ca151d0/attachment.html>