[Asterisk-code-review] func_lookup: Fork of HINT function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_lookup: Fork of HINT function
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> Except for the single post on here that this would be helpful, there were no other responses across  […]
If the -2 was something else, like -666, would that make any difference? Or if there was no impact on the core, and users just hardcoded a -(priority), though not as clean?

Fundamentally the power of LOOKUP relies on being in the dialplan, since you can have things like this:

[lookup]
exten => _3XX,lookup,${CALLERID(num)})
exten => _41X,lookup,${LOOKUP(${EPOCH}@another-lookup)}
exten => _42X,lookup,${CURL(https://example.com/api/${EXTEN})})

It seems some of that power would go away if it wasn't in the dialplan. A static lookup function without extension pattern matching and without channel variable resolution would be completely useless.

I have these interspersed throughout my dialplan in lots of different ways, and this is arguably the biggest enhancement I've encountered in years (JMHO).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 22:25:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/b33df3da/attachment.html>