[Asterisk-code-review] func_lookup: Fork of HINT function (asterisk[master])
Joshua Colp
asteriskteam at digium.com
Mon Jul 19 17:17:47 CDT 2021
Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )
Change subject: func_lookup: Fork of HINT function
......................................................................
Patch Set 4: Code-Review-2
(1 comment)
Patchset:
PS4:
Except for the single post on here that this would be helpful, there were no other responses across the various user places from individuals regarding this feature. Due to the fact that this still modifies the PBX core (by introducing a -2 priority which can then leak out in places) and turns dialplan extensions into a key/value store I am not comfortable including this in Asterisk. If this required NO changes to the PBX core (that is - no -2 priority) and things were configured in its own isolated .conf file, then it would be a truly isolated module and would be eligible.
Do any developers disagree?
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 22:17:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/0ee990c8/attachment.html>
More information about the asterisk-code-review
mailing list