[Asterisk-code-review] res_rtp_asterisk: Automatically refresh stunaddr from DNS (asterisk[16])

[Joshua Colp]

Attention is currently required from: Sébastien Duthil.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16168 )

Change subject: res_rtp_asterisk: Automatically refresh stunaddr from DNS
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/16168/comment/d5f75a0d_3976f3f6 
PS1, Line 3658: 	stunaddr_pointer = &stunaddr;
If this is trying to ensure that the value of stunaddr doesn't change during usage, this won't work. The contents could still change, and this is the equivalent to the way it was before currently.


https://gerrit.asterisk.org/c/asterisk/+/16168/comment/f7f58451_cdf385e6 
PS1, Line 3667: 		ast_sockaddr_to_sin(stunaddr_pointer, &stun_sin);
Do we need to do this each time? It feels as though storing it in the format it would be used most commonly would be better.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16168
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7955a046293f913ba121bbd82153b04439e3465f
Gerrit-Change-Number: 16168
Gerrit-PatchSet: 1
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Comment-Date: Thu, 15 Jul 2021 12:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210715/ef30d5cd/attachment.html>