<p> Attention is currently required from: Sébastien Duthil. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16168">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16168/comment/d5f75a0d_3976f3f6">Patch Set #1, Line 3658:</a> <code style="font-family:monospace,monospace"> stunaddr_pointer = &stunaddr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If this is trying to ensure that the value of stunaddr doesn't change during usage, this won't work. The contents could still change, and this is the equivalent to the way it was before currently.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16168/comment/f7f58451_cdf385e6">Patch Set #1, Line 3667:</a> <code style="font-family:monospace,monospace">               ast_sockaddr_to_sin(stunaddr_pointer, &stun_sin);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we need to do this each time? It feels as though storing it in the format it would be used most commonly would be better.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16168">change 16168</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16168"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I7955a046293f913ba121bbd82153b04439e3465f </div>
<div style="display:none"> Gerrit-Change-Number: 16168 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sébastien Duthil <sduthil@wazo.community> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Sébastien Duthil <sduthil@wazo.community> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 15 Jul 2021 12:51:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>