[Asterisk-code-review] stun: Emit warning message when STUN request times out (asterisk[16])

[Sébastien Duthil]

Attention is currently required from: Sean Bright, Joshua Colp.
Sébastien Duthil has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16166 )

Change subject: stun: Emit warning message when STUN request times out
......................................................................


Patch Set 2:

(3 comments)

File main/stun.c:

https://gerrit.asterisk.org/c/asterisk/+/16166/comment/1892f30e_725d47bf 
PS1, Line 441: 				ast_log(LOG_WARNING, "STUN request number %d timed out.\n", retry);
> I don't think from a user perspective this is detailed or friendly enough. […]
Thank you for the suggestion. Updated.


File main/stun.c:

https://gerrit.asterisk.org/c/asterisk/+/16166/comment/1e109cb5_b61bf33c 
PS2, Line 444: 					retry,
> retry + 1
That's what I also thought initially, but retry takes the values 1,2,3 thanks to line 413:

```
	for (retry = 0; retry++ < 3;) {
```

The current version displays:
```
Attempt 1 to send STUN request...
...
Attempt 2 to send STUN request...
...
Attempt 3 to send STUN request...
```

Thank you for bringing it up :)


https://gerrit.asterisk.org/c/asterisk/+/16166/comment/80596d75_f029a6de 
PS2, Line 459: 					retry,
> Ditto
See above.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16166
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26e4853c23a1aed324552e1b9683ea3c05cb1f74
Gerrit-Change-Number: 16166
Gerrit-PatchSet: 2
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 12:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/7530abf2/attachment.html>