<p> Attention is currently required from: Sean Bright, Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16166">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File main/stun.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16166/comment/1892f30e_725d47bf">Patch Set #1, Line 441:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_WARNING, "STUN request number %d timed out.\n", retry);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't think from a user perspective this is detailed or friendly enough. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Thank you for the suggestion. Updated.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/stun.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16166/comment/1e109cb5_b61bf33c">Patch Set #2, Line 444:</a> <code style="font-family:monospace,monospace"> retry,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">retry + 1</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">That's what I also thought initially, but retry takes the values 1,2,3 thanks to line 413:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">```<br> for (retry = 0; retry++ < 3;) {<br>```</pre><p style="white-space: pre-wrap; word-wrap: break-word;">The current version displays:<br>```<br>Attempt 1 to send STUN request...<br>...<br>Attempt 2 to send STUN request...<br>...<br>Attempt 3 to send STUN request...<br>```</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thank you for bringing it up :)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16166/comment/80596d75_f029a6de">Patch Set #2, Line 459:</a> <code style="font-family:monospace,monospace"> retry,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Ditto</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">See above.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16166">change 16166</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16166"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I26e4853c23a1aed324552e1b9683ea3c05cb1f74 </div>
<div style="display:none"> Gerrit-Change-Number: 16166 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sébastien Duthil <sduthil@wazo.community> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Jul 2021 12:30:32 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>