[Asterisk-code-review] res_statsd: replace meter type with counter (asterisk[16])

Joshua Colp asteriskteam at digium.com
Thu Jul 8 06:34:37 CDT 2021


Attention is currently required from: Rijnhard Hessel.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16149 )

Change subject: res_statsd: replace meter type with counter
......................................................................


Patch Set 3:

(1 comment)

File res/res_chan_stats.c:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/3865355c_6756c236 
PS1, Line 76: 		ast_statsd_log(ast_str_buffer(metric), AST_STATSD_COUNTER, 1);
> I can attempt that yes. […]
I think a simple "meter_support", with documentation of what happens to meters if disabled (counter will be used instead).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 3
Gerrit-Owner: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Comment-Date: Thu, 08 Jul 2021 11:34:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/73c7fa34/attachment.html>


More information about the asterisk-code-review mailing list