[Asterisk-code-review] res_statsd: replace meter type with counter (asterisk[16])

[Rijnhard Hessel]

Attention is currently required from: Joshua Colp.
Rijnhard Hessel has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16149 )

Change subject: res_statsd: replace meter type with counter
......................................................................


Patch Set 3:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/eb811693_77edc46f 
PS1, Line 8: 
> This commit message needs more explanation as to why this change is being done.
Done


File include/asterisk/statsd.h:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/1faba902_1f432cc3 
PS1, Line 44: /*! Events over time. Sorta like increment-only counters. */
> Yes.
Done


File res/res_chan_stats.c:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/6debd060_4d55f6a4 
PS1, Line 76: 		ast_statsd_log(ast_str_buffer(metric), AST_STATSD_COUNTER, 1);
> Could we not add an option which defaults to "yes" which sets whether it is supported or not, which  […]
I can attempt that yes.
something like a config option of use_meter or enable_meter?
not sure about config key standards.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 3
Gerrit-Owner: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 11:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/3b2613af/attachment.html>