[Asterisk-code-review] app_reload: New Reload application (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Kevin Harwell.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15962 )

Change subject: app_reload: New Reload application
......................................................................


Patch Set 6: Code-Review-1

(3 comments)

File apps/app_reload.c:

https://gerrit.asterisk.org/c/asterisk/+/15962/comment/77ebadcc_a13cf8d5 
PS6, Line 43: 			Reloads an Asterisk module.
I think this needs documentation that this application will block while reloading the given module(s) and if it takes a long time then the channel will be blocked and waiting.


https://gerrit.asterisk.org/c/asterisk/+/15962/comment/f027cd10_8bc69533 
PS6, Line 56: 			that if a module is reloaded successfully but there are errors with the configuration,
This isn't completely accurate, it's up to the underlying module what it does.


https://gerrit.asterisk.org/c/asterisk/+/15962/comment/958ec30b_7ae1b00d 
PS6, Line 65: 						Intended module(s) not completely reloaded successfully.
If multiple modules are specified but only one fails, then to the dialplan it is returned that failure occurred - when some were successful. I think this documentation needs to be adjusted to be clear about that:

"If multiple modules are specified and any module fails, then FAILURE will be returned. It is still possible that other modules did successfully reload however."

Something like that.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic8ab025d8b38dd525b872b41c465c999c5810774
Gerrit-Change-Number: 15962
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 09:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210706/3dba72fd/attachment-0001.html>