<p> Attention is currently required from: N A, Kevin Harwell. </p>
<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15962">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_reload.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15962/comment/77ebadcc_a13cf8d5">Patch Set #6, Line 43:</a> <code style="font-family:monospace,monospace">                        Reloads an Asterisk module.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this needs documentation that this application will block while reloading the given module(s) and if it takes a long time then the channel will be blocked and waiting.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15962/comment/f027cd10_8bc69533">Patch Set #6, Line 56:</a> <code style="font-family:monospace,monospace">                    that if a module is reloaded successfully but there are errors with the configuration,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This isn't completely accurate, it's up to the underlying module what it does.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15962/comment/958ec30b_7ae1b00d">Patch Set #6, Line 65:</a> <code style="font-family:monospace,monospace">                                          Intended module(s) not completely reloaded successfully.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If multiple modules are specified but only one fails, then to the dialplan it is returned that failure occurred - when some were successful. I think this documentation needs to be adjusted to be clear about that:</p><p style="white-space: pre-wrap; word-wrap: break-word;">"If multiple modules are specified and any module fails, then FAILURE will be returned. It is still possible that other modules did successfully reload however."</p><p style="white-space: pre-wrap; word-wrap: break-word;">Something like that.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15962">change 15962</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15962"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ic8ab025d8b38dd525b872b41c465c999c5810774 </div>
<div style="display:none"> Gerrit-Change-Number: 15962 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Jul 2021 09:05:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>