[Asterisk-code-review] pjproject: Bump the version after the SDP file was negotiated (asterisk[18])

[Holger Hans Peter Freyther]

Holger Hans Peter Freyther has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15305 )

Change subject: pjproject: Bump the version after the SDP file was negotiated
......................................................................


Patch Set 2:

(1 comment)

I filed https://github.com/pjsip/pjproject/issues/2620

https://gerrit.asterisk.org/c/asterisk/+/15305/2//PATCHSET_LEVEL 
File /PATCHSET_LEVEL:

PS2: 
> Has this change been provided upstream to Teluu and gone through their review process?
Not yet. I wanted to see how Asterisk thinks this should behave. E.g. which side should own the session version. Does that make any sense?


Interaction:
In Asterisk we try to increase the version (e.g. create_local_sdp of res_pjsip_session.c) but I think pjmedia has its very own idea of version handling by overwriting the version increment in asterisk.

https://github.com/pjsip/pjproject/blob/master/pjmedia/src/pjmedia/sdp_neg.c#L411 (overwriting the version any caller provides)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15305
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I4d082d7dd916dc713774a445eee272bad52a7e59
Gerrit-Change-Number: 15305
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 20 Jan 2021 13:46:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210120/6bad70ff/attachment.html>