<p style="white-space: pre-wrap; word-wrap: break-word;">I filed https://github.com/pjsip/pjproject/issues/2620</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15305">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15305/2//PATCHSET_LEVEL">File /PATCHSET_LEVEL:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15305/2//PATCHSET_LEVEL">Patch Set #2:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Has this change been provided upstream to Teluu and gone through their review process?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not yet. I wanted to see how Asterisk thinks this should behave. E.g. which side should own the session version. Does that make any sense?</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>Interaction:<br>In Asterisk we try to increase the version (e.g. create_local_sdp of res_pjsip_session.c) but I think pjmedia has its very own idea of version handling by overwriting the version increment in asterisk.</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://github.com/pjsip/pjproject/blob/master/pjmedia/src/pjmedia/sdp_neg.c#L411 (overwriting the version any caller provides)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15305">change 15305</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15305"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: I4d082d7dd916dc713774a445eee272bad52a7e59 </div>
<div style="display:none"> Gerrit-Change-Number: 15305 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Holger Hans Peter Freyther <automatic@freyther.de> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Jan 2021 13:46:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>