[Asterisk-code-review] app_mixmonitor: Add AMI events MixMonitorStart, -Stop and -Mute. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15325 )

Change subject: app_mixmonitor: Add AMI events MixMonitorStart, -Stop and -Mute.
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

This change also needs a CHANGES file to be added[1].

[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt

https://gerrit.asterisk.org/c/asterisk/+/15325/3//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15325/3//COMMIT_MSG@8 
PS3, Line 8: 
This needs the ASTERISK- issue identifier added.


https://gerrit.asterisk.org/c/asterisk/+/15325/3/apps/app_mixmonitor.c 
File apps/app_mixmonitor.c:

https://gerrit.asterisk.org/c/asterisk/+/15325/3/apps/app_mixmonitor.c@1282 
PS3, Line 1282: 	pbx_builtin_setvar_helper(chan, "MIXMONITOR_ENABLED", "0");
              : 	pbx_builtin_setvar_helper(chan, "MIXMONITOR_READ_MUTED", "0");
              : 	pbx_builtin_setvar_helper(chan, "MIXMONITOR_WRITE_MUTED", "0");
These appear to be additional functionality that have been added, outside of this patch.


https://gerrit.asterisk.org/c/asterisk/+/15325/3/main/manager_channels.c 
File main/manager_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/15325/3/main/manager_channels.c@1119 
PS3, Line 1119: static void channel_mixmonitor_start_cb(void *data, struct stasis_subscription *sub,
These new events will need managerEvent XML added to apps/app_mixmonitor.c to describe them for the wiki documentation.


https://gerrit.asterisk.org/c/asterisk/+/15325/3/main/manager_channels.c@1371 
PS3, Line 1371:     ast_channel_mixmonitor_start_type(), channel_mixmonitor_start_cb, NULL);
The indentation appears to be off here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15325
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1862d58264c2c8b5d8983272cb29734b184d67c5
Gerrit-Change-Number: 15325
Gerrit-PatchSet: 3
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 20 Jan 2021 11:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210120/a9d2fde8/attachment-0001.html>