<p style="white-space: pre-wrap; word-wrap: break-word;">This change also needs a CHANGES file to be added[1].</p><p style="white-space: pre-wrap; word-wrap: break-word;">[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt</p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15325">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15325/3//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15325/3//COMMIT_MSG@8">Patch Set #3, Line 8:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This needs the ASTERISK- issue identifier added.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15325/3/apps/app_mixmonitor.c">File apps/app_mixmonitor.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15325/3/apps/app_mixmonitor.c@1282">Patch Set #3, Line 1282:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  pbx_builtin_setvar_helper(chan, "MIXMONITOR_ENABLED", "0");<br>       pbx_builtin_setvar_helper(chan, "MIXMONITOR_READ_MUTED", "0");<br>    pbx_builtin_setvar_helper(chan, "MIXMONITOR_WRITE_MUTED", "0");<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These appear to be additional functionality that have been added, outside of this patch.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15325/3/main/manager_channels.c">File main/manager_channels.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15325/3/main/manager_channels.c@1119">Patch Set #3, Line 1119:</a> <code style="font-family:monospace,monospace">static void channel_mixmonitor_start_cb(void *data, struct stasis_subscription *sub,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">These new events will need managerEvent XML added to apps/app_mixmonitor.c to describe them for the wiki documentation.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15325/3/main/manager_channels.c@1371">Patch Set #3, Line 1371:</a> <code style="font-family:monospace,monospace">    ast_channel_mixmonitor_start_type(), channel_mixmonitor_start_cb, NULL);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The indentation appears to be off here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15325">change 15325</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15325"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1862d58264c2c8b5d8983272cb29734b184d67c5 </div>
<div style="display:none"> Gerrit-Change-Number: 15325 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Sébastien Duthil <sduthil@wazo.community> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Jan 2021 11:58:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>