[Asterisk-code-review] chan_pjsip: Incorporate channel reference count into transfer_refer(). (asterisk[16])

[Joshua Colp]

Attention is currently required from: Dan Cropp.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15195 )

Change subject: chan_pjsip: Incorporate channel reference count into transfer_refer().
......................................................................


Patch Set 3: Code-Review-1

(6 comments)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/15195/comment/4530481f_f0f9ae0e 
PS3, Line 1944: 				pjsip_evsub_set_mod_data(sub, refer_callback_module.id, NULL);
Add a comment that the channel reference on this will be unreferenced later


https://gerrit.asterisk.org/c/asterisk/+/15195/comment/8e54f57c_fc998c1d 
PS3, Line 2010: 		ao2_cleanup(chan);
chan is guaranteed to be non-NULL so this can be ao2_ref


https://gerrit.asterisk.org/c/asterisk/+/15195/comment/c9b8d9d0_37b1b3b7 
PS3, Line 2035: 	pjsip_evsub_set_mod_data(sub, refer_callback_module.id, chan);
Comment that refer_callback_module will have a reference to chan and state the function where it will be released eventually


https://gerrit.asterisk.org/c/asterisk/+/15195/comment/20e49463_e3e83b72 
PS3, Line 2038: 	if (pjsip_xfer_initiate(sub, pj_cstr(&tmp, target), &packet) != PJ_SUCCESS)
Enclose in { and }


https://gerrit.asterisk.org/c/asterisk/+/15195/comment/24842d74_681f3947 
PS3, Line 2040: 	
Redness


https://gerrit.asterisk.org/c/asterisk/+/15195/comment/f5794679_880f9558 
PS3, Line 2049: 	if (pjsip_xfer_send_request(sub, packet) == PJ_SUCCESS)
This should be enclosed with { and }



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15195
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3fd92fd14b4e3844d3d7b0f60fe417a4df5f2435
Gerrit-Change-Number: 15195
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Dan Cropp <dan at amtelco.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 11:26:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210105/08656219/attachment.html>