<p> Attention is currently required from: Dan Cropp. </p>
<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15195">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15195/comment/4530481f_f0f9ae0e">Patch Set #3, Line 1944:</a> <code style="font-family:monospace,monospace">                          pjsip_evsub_set_mod_data(sub, refer_callback_module.id, NULL);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add a comment that the channel reference on this will be unreferenced later</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15195/comment/8e54f57c_fc998c1d">Patch Set #3, Line 2010:</a> <code style="font-family:monospace,monospace">           ao2_cleanup(chan);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">chan is guaranteed to be non-NULL so this can be ao2_ref</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15195/comment/c9b8d9d0_37b1b3b7">Patch Set #3, Line 2035:</a> <code style="font-family:monospace,monospace">  pjsip_evsub_set_mod_data(sub, refer_callback_module.id, chan);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comment that refer_callback_module will have a reference to chan and state the function where it will be released eventually</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15195/comment/20e49463_e3e83b72">Patch Set #3, Line 2038:</a> <code style="font-family:monospace,monospace">  if (pjsip_xfer_initiate(sub, pj_cstr(&tmp, target), &packet) != PJ_SUCCESS)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Enclose in { and }</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15195/comment/24842d74_681f3947">Patch Set #3, Line 2040:</a> <code style="font-family:monospace,monospace">       </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Redness</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15195/comment/f5794679_880f9558">Patch Set #3, Line 2049:</a> <code style="font-family:monospace,monospace">     if (pjsip_xfer_send_request(sub, packet) == PJ_SUCCESS)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be enclosed with { and }</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15195">change 15195</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15195"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I3fd92fd14b4e3844d3d7b0f60fe417a4df5f2435 </div>
<div style="display:none"> Gerrit-Change-Number: 15195 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Dan Cropp <dan@amtelco.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Dan Cropp <dan@amtelco.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 05 Jan 2021 11:26:44 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>