[Asterisk-code-review] tcptls.c: refactor client connection to be more robust (asterisk[16])

[Sean Bright]

Attention is currently required from: Kevin Harwell.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17720 )

Change subject: tcptls.c: refactor client connection to be more robust
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

File include/asterisk/tcptls.h:

https://gerrit.asterisk.org/c/asterisk/+/17720/comment/7e5954b3_6981f6b8 
PS2, Line 167:   * \brief Attempt to connect, and start a tcptls session within the given timeout
I don't think the comma is needed


https://gerrit.asterisk.org/c/asterisk/+/17720/comment/44dffd87_3b7cbbfe 
PS2, Line 169:   * Note, on error the tcptls_session's ref count is decremented,* fd and file
Use \note here? You also have an errant * after 'decremented.'


https://gerrit.asterisk.org/c/asterisk/+/17720/comment/ebba92bc_b66e196b 
PS2, Line 181:   * \brief Attempt to connect, and start a tcptls session
I don't think the comma is needed


https://gerrit.asterisk.org/c/asterisk/+/17720/comment/3037d607_6b158f80 
PS2, Line 185:   * Note, on error the tcptls_session's ref count is decremented,* fd and file
Use \note here? You also have an errant * after 'decremented.'


File main/tcptls.c:

https://gerrit.asterisk.org/c/asterisk/+/17720/comment/7026e829_9f5d885f 
PS2, Line 663: 	ast_fd_clear_flags(desc->accept_fd, O_NONBLOCK);
Potentially dumb question, but: Why are we clearing O_NONBLOCK here but...


https://gerrit.asterisk.org/c/asterisk/+/17720/comment/fca076ea_8cf6032f 
PS2, Line 692: 	fd = desc->accept_fd = ast_socket_nonblock(ast_sockaddr_is_ipv6(&desc->remote_address) ?
... explicitly asking for it here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17720
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I907571843a83e43c0742b95a64785f4411f02671
Gerrit-Change-Number: 17720
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 28 Dec 2021 21:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211228/ddb11172/attachment.html>